[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] MI: Replace sequence number with ID

From: Jose E. Marchesi
Subject: Re: [PATCH v2] MI: Replace sequence number with ID
Date: Tue, 09 Nov 2021 23:26:53 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

> On Tue, Nov 09, 2021 at 09:18:18PM +0100, Jose E. Marchesi wrote:
>> >
>> > The answer for both questions:
>> >   "to make testing easier by having perdictable IDs for messages"
>> But you see, that is exactly my point: message IDs must not be
>> predictable: they don't absolutely need to, and also it is probably a
>> good idea for them to not be.
>> The client implementations should not rely on predictable IDs, and the
>> same can be said about the server implementation (poke itself.)
>> If we are going to test the MI as a black-box, I don't think we need to
>> check for the validity of IDs at all.
>> I have nothing in principle against using different ID "namespaces" for
>> responses and events, but they complicate the implementation and IMO it
>> is unnecessary.
> OK. Makes sense. I'll ignore them completely in tests :)
> Thanks for your explanation!

No, thanks to you for working on these tests :)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]