[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] pkl: Disallow pinned unions
|
From: |
Mohammad-Reza Nabipoor |
|
Subject: |
Re: [PATCH 1/2] pkl: Disallow pinned unions |
|
Date: |
Tue, 18 Jan 2022 17:21:22 +0330 |
Hi, Jose.
On Tue, Jan 18, 2022 at 01:36:37PM +0100, Jose E. Marchesi wrote:
>
> Hi Mohammad.
>
> > 2022-01-18 Mohammad-Reza Nabipoor <mnabipoor@gnu.org>
> >
> > * libpoke/pkl-typify.c (pkl_typify1_ps_type_struct): Disallow
> > pinned unions.
> > * doc/poke.texi (Unions): Update.
> > * testsuite/poke.pkl/pinned-union-1.pk: New test.
>
> We conventionally use the -diag suffix in the names of tests that check
> for compilation errors. So I would name that test
> `pinned-union-diag-1.pk' instead.
>
Fixed.
> Other than that, this is OK for master.
Pushed.
> Thanks for the patch.
My pleasure!