Re: [PATCH 1/2] doc: Remove outdated HTML generation bug workarounds

[Jose E. Marchesi]

Hi Arsen.
OK for master.
Thanks.

> These seds appear to have been working around bugs in older Texinfo
> versions, however, on Texinfo 7.0 or later, all they do is break the
> index page.
>
> 2023-01-17  Arsen Arsenović  <arsen@aarsen.me>
>
>       * doc/Makefile.am (html-local): Remove outdated workaround for
>       bug in older Texinfo versions.
> ---
> Afternoon,
>
> This patchset adds some contents to the top node of the manual, and removes 
> the
> html-local hacks.  The latter appear to be irrelevant now, at least as seen
> with Texinfo 7.0.1 (and 7.0, IIRC), and the former serves as a small
> introduction to the manual itself, so that less context is required when
> opening it for the first time.
>
> You can see this updated manual here:
> https://www.aarsen.me/~arsen/poke.html/index.html (generated against the 
> Gnulib
> manual.css)
>
> Removing the hack produced the following diff with the current master:
> https://www.aarsen.me/~arsen/poke.html/html-local-diff.patch
>
> OK for master?
>
> Thanks in advance, have a great day.
>
>  ChangeLog       |  5 +++++
>  doc/Makefile.am | 19 -------------------
>  2 files changed, 5 insertions(+), 19 deletions(-)
>
> diff --git a/ChangeLog b/ChangeLog
> index 62787f7e..ddd0f6b2 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,8 @@
> +2023-01-17  Arsen Arsenović  <arsen@aarsen.me>
> +
> +     * doc/Makefile.am (html-local): Remove outdated workaround for bug
> +     in older Texinfo versions.
> +
>  2023-01-16  Arsen Arsenović  <arsen@aarsen.me>
>  
>       * cfg.mk (sc_tests_listed_in_makefile_am): Modernize egrep
> diff --git a/doc/Makefile.am b/doc/Makefile.am
> index 1bff5881..197d5bd7 100644
> --- a/doc/Makefile.am
> +++ b/doc/Makefile.am
> @@ -68,25 +68,6 @@ INFO_DEPS = $(srcdir)/poke.info
>  
>  app_DATA = nodelist
>  
> -# Generation of the HTML manual.
> -#
> -# We do some changes in the .html files generated by makeinfo:
> -#
> -# - The "Table of Contents" in poke.html/index.html is not emitted.
> -#   This is because the Top node also provides a table of contents,
> -#   that is much more informative.
> -#
> -# - makeinfo generates an <h3> for footnote marks (N).  This looks
> -#   like a bug, since the "Footnotes" heading is <h4> itself.  Using a
> -#   header for this is ugly anyway.
> -
> -html-local:
> -     sed -i -e '/^<h2.*contents-heading.*/,/<a name="Top">.*/d' \
> -               -e 's/^<h1.*settitle.*//' \
> -       $(builddir)/poke.html/index.html
> -     sed -i -e 's#^<h3>\(.*name="FOOT.*\)</h3>#<strong>\1</strong>#' \
> -       $(builddir)/poke.html/*.html
> -
>  # Generation of the plain text manual.
>  # We distribute it in the tarballs, since it requires makeinfo to make.