[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [COMMITTED] pk-repl: Redraw screen after displaying multi-word compl
From: |
Jose E. Marchesi |
Subject: |
Re: [COMMITTED] pk-repl: Redraw screen after displaying multi-word completion |
Date: |
Thu, 19 Jan 2023 17:06:19 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) |
Hello Arsen.
Thans for the patch.
OK for master.
> It'd appear that, instead of only skipping displaying matches, providing
> rl_completion_display_matches_hook also makes readline skip redrawing
> the screen, leading to garbled contents. This fixes completing the .doc
> command.
>
> See also:
> https://git.sv.gnu.org/cgit/readline.git/tree/complete.c?h=readline-8.2#n1750
>
> 2023-01-19 Arsen Arsenović <arsen@aarsen.me>
>
> * poke/pk-repl.c (space_substitute_display_matches): Force
> redisplay after displaying match list, to match GNU Readline
> behavior.
> ---
> ChangeLog | 6 ++++++
> poke/pk-repl.c | 1 +
> 2 files changed, 7 insertions(+)
>
> diff --git a/ChangeLog b/ChangeLog
> index cb33df44..f19da7cb 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,9 @@
> +2023-01-19 Arsen Arsenović <arsen@aarsen.me>
> +
> + * poke/pk-repl.c (space_substitute_display_matches): Force
> + redisplay after displaying match list, to match GNU Readline
> + behavior.
> +
> 2023-01-18 Mohammad-Reza Nabipoor <mnabipoor@gnu.org>
>
> * poked/poked.c (VUCMD_*): Re-enumerate the view (vu) commands.
> diff --git a/poke/pk-repl.c b/poke/pk-repl.c
> index 7d21afaf..4f4413ed 100644
> --- a/poke/pk-repl.c
> +++ b/poke/pk-repl.c
> @@ -97,6 +97,7 @@ space_substitute_display_matches (char **matches, int
> num_matches,
> }
>
> rl_display_match_list (matches, num_matches, max_length);
> + rl_forced_update_display ();
> }
>
> /* Display the rl_line_buffer substituting