[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] ios: track sub IOS devices

From: Mohammad-Reza Nabipoor
Subject: Re: [PATCH v2] ios: track sub IOS devices
Date: Sat, 29 Apr 2023 15:06:44 +0200

Hi Jose.

On Sun, Apr 23, 2023 at 03:11:15PM +0200, Jose E. Marchesi wrote:
> > In this commit, we keep track of number of sub-devices for each
> > IO space.  If the user close the super-IOS, it'll become a zombie
> > IOS: it's dead but the corresponding `struct ios' is not un-allocated
> > yet.  When user closes the sub-IOS, and if it's the last sub-IOS,
> > it'll de-allocate the corresponding `struct ios'.
> I like this idea.  But I would suggest to move the sub-spaces business
> completely to the IOS, at this point, instead of keeping a "sub" IOD.

IMHO moving the logic from `ios-dev-sub.c' to `ios.c', only complicates the
`ios.c' with no obvious benefits.  I think keep the sub IOD is a good thing.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]