poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] pk-utils: change pk_print_binary func to macro


From: Jose E. Marchesi
Subject: Re: [PATCH 1/3] pk-utils: change pk_print_binary func to macro
Date: Tue, 14 Nov 2023 23:35:19 +0100
User-agent: Gnus/5.13 (Gnus v5.13)

> Hi Jose.
>
> On Tue, Nov 14, 2023 at 08:29:08PM +0100, Jose E. Marchesi wrote:
>> 
>> Hi Mohammad.
>> 
>> I don't think it is worth it keeping a pk_integral_suffix function.  Why
>> not incorporating its logit to the PK_PRINT_BINARY macro?
>> 
>
> Because of Jitter!
> We cannot use string literals in instructions (we're using PVM_PRINT_BINARY
> both in PVM_PRINT{I,L} macros in pvm.jitter).

Damn.  Ok, please add a big fat comment explaining that in pk-utils.h!
Given that, OK.

Thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]