[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Pspp-commits] [SCM] GNU PSPP branch, master, updated. v0.7.9-251-gc70fe

From: Ben Pfaff
Subject: [Pspp-commits] [SCM] GNU PSPP branch, master, updated. v0.7.9-251-gc70fe01
Date: Mon, 09 Jul 2012 06:28:18 +0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU PSPP".

The branch, master has been updated
       via  c70fe01eeffe530040004eae26c655dd1682f1bf (commit)
       via  e8fb3677342a64a1d93825e5f158d1612561a033 (commit)
      from  041b19c514c26a0c1b24e163d171a44694024f97 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c70fe01eeffe530040004eae26c655dd1682f1bf
Author: Ben Pfaff <address@hidden>
Date:   Sun Jul 8 23:27:52 2012 -0700

    psppire-data-editor: Unref old data_window upon change.
    Otherwise there's a reference leak.
    Found by inspection; I haven't looked for clients that actually
    change the data window after setting it.

commit e8fb3677342a64a1d93825e5f158d1612561a033
Author: Ben Pfaff <address@hidden>
Date:   Sat Jul 7 23:44:37 2012 -0700

    psppire-data-window: Delete dataset when closing window.
    When the user closes the window it means that he wants to close the
    underlying dataset also.  Otherwise the dataset essentially leaks
    (in theory it's still there in the list of datasets but in practice
    that takes a DATASET ACTIVATE <name> WINDOW=FRONT command to show
    This also fixes a Gtk-CRITICAL and following crash in the following
    scenario brought up by John Darrington:
    1. Start psppire
    2. File | Open and load x.sav (dataset1)
    3. File | New | Data (a new data window will appear: dataset2)
    4. Using the window manager close the window for dataset1
    5. In dataset2:  File | Open and load x.sav
    I'm not 100% certain of the reason that this fixes it but I think
    that there's some lingering association between the dataset and the
    window that this change eliminates, by eliminating the dataset along
    with the window.
    The code added to psppire_data_window_dispose() in this commit
    should probably go in a "finalize" function instead but there seems
    to be a separate problem with references to PsppireVarSheet such
    that if this new code is in "finalize" then dataset_destroy() will
    call dict_clear() which will invoke the callbacks for PsppireDict
    which will try to access the destroyed window.  On the other hand,
    with this code in "dispose" the window isn't fully destroyed yet so
    while the same code path gets followed it isn't fatal.


Summary of changes:
 src/ui/gui/psppire-data-editor.c |    2 ++
 src/ui/gui/psppire-data-window.c |   12 ++++++++++++
 2 files changed, 14 insertions(+), 0 deletions(-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]