[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Pspp-commits] [SCM] GNU PSPP branch, master, updated. v0.7.9-858-gdb161

From: Ben Pfaff
Subject: [Pspp-commits] [SCM] GNU PSPP branch, master, updated. v0.7.9-858-gdb16106
Date: Tue, 21 May 2013 06:50:15 +0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU PSPP".

The branch, master has been updated
       via  db161068bfd5b6685f909f39b2a4701ed4941b03 (commit)
      from  6c15f78893f677ccdd45715640bf79961011d529 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit db161068bfd5b6685f909f39b2a4701ed4941b03
Author: Ben Pfaff <address@hidden>
Date:   Mon May 20 23:49:54 2013 -0700

    DELETE VARIABLES: Fix crash with FILTER.
    FILTER has the surprising property that it introduces a temporary
    transformation, even if proc_make_temporary_transformations_permanent()
    was previously called.  This causes a crash if the procedure implementation
    really relies on there being no temporary transformations.
    This commit fixes the problem in the procedures I was able to identify as
    having it, adds a comment to proc_make_temporary_transformations_permanent()
    to make it a little less likely to happen again, and adds a test
    specifically to check for regression on DELETE VARIABLES.
    Reported by John Darrington.
    Bug #38843.


Summary of changes:
 src/data/dataset.c                            |   10 ++++++--
 src/language/data-io/combine-files.c          |    2 +-
 src/language/dictionary/delete-variables.c    |    4 +-
 src/language/stats/descriptives.c             |    3 +-
 src/language/stats/flip.c                     |    2 +-
 src/language/stats/regression.c               |    9 +++++--
 tests/                             |    1 +
 tests/language/dictionary/ |   29 +++++++++++++++++++++++++
 8 files changed, 49 insertions(+), 11 deletions(-)
 create mode 100644 tests/language/dictionary/


reply via email to

[Prev in Thread] Current Thread [Next in Thread]