[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Pspp-commits] [SCM] GNU PSPP branch, master, updated. v0.7.9-878-g3b07f

From: Ben Pfaff
Subject: [Pspp-commits] [SCM] GNU PSPP branch, master, updated. v0.7.9-878-g3b07fcc
Date: Thu, 13 Jun 2013 07:11:07 +0000

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU PSPP".

The branch, master has been updated
       via  3b07fccffef73bba4bb1839fced20554df75901e (commit)
       via  a352ef204364d7b21036777ea40d6fa6046bae5f (commit)
      from  e7f588b1dae961829622e2663ed0f4b67f016e32 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 3b07fccffef73bba4bb1839fced20554df75901e
Author: Ben Pfaff <address@hidden>
Date:   Thu Jun 13 00:03:51 2013 -0700

    INPUT PROGRAM: Use a separate dataset for the input program.
    Without this change, INPUT PROGRAM uses the same dataset as the following
    syntax.  This usually is fine, but there's at least one case where it
    doesn't work: if the INPUT PROGRAM defines a vector, then a following
    proc_execute() without any intervening transformations causes
    proc_execute() to follow a "fast path" where it skips running the procedure
    but instead just does a few things, like clearing the set of vectors.
    Unfortunately, this means that later when the input program is really run,
      it doesn't have the vectors and accesses freed memory.
    This commit switches to a different tactic.  INPUT PROGRAM creates a
    special session and dataset that are used only for the input program.  This
    keeps the dataset and the transformations used for the input program
    separate from those used after the input program.
    Bug #39097.
    Reported by John Darrington.

commit a352ef204364d7b21036777ea40d6fa6046bae5f
Author: Ben Pfaff <address@hidden>
Date:   Tue Jun 4 23:25:36 2013 -0700

    command.def: Disallow DATASET commands inside INPUT PROGRAM, FILE TYPE.
    It doesn't make sense to try to switch datasets within INPUT PROGRAM, and
    so we shouldn't allow it.


Summary of changes:
 src/data/session.c                 |   13 +++++++++----
 src/data/session.h                 |    4 ++--
 src/language/command.def           |   14 +++++++-------
 src/language/data-io/inpt-pgm.c    |   25 ++++++++++++++-----------
 src/ui/gui/psppire-data-window.c   |    4 ++--
 src/ui/terminal/main.c             |    4 ++--
 tests/language/data-io/ |   34 ++++++++++++++++++++++++++++++++++
 7 files changed, 70 insertions(+), 28 deletions(-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]