[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Pspp-commits] [SCM] GNU PSPP branch, master, updated. v1.5.5-8-g453a25e

From: Ben Pfaff
Subject: [Pspp-commits] [SCM] GNU PSPP branch, master, updated. v1.5.5-8-g453a25eb0
Date: Fri, 27 May 2022 21:33:35 -0400 (EDT)

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU PSPP".

The branch, master has been updated
       via  453a25eb0d3ef50989735fc68ae3f17e5b318c8c (commit)
       via  4f3cf328723cf70c06702904e85768d6601918a2 (commit)
       via  66c5538861e0e29333b1b0ee83ea2c548c08fd8f (commit)
       via  a0ee1f3ba1dd37945983ea651c98b49b318d3e2f (commit)
       via  9942b071bb615a4133d6edce68d79eb0538e9819 (commit)
      from  c92d3eed244f3958c01daf3ab901fbe2faa2b735 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 453a25eb0d3ef50989735fc68ae3f17e5b318c8c
Author: Ben Pfaff <>
Date:   Fri May 27 18:29:20 2022 -0700

    gui: For text data import, use the same parser for preview as for import.
    There were odd discrepancies between the preview code in the GUI for
    text data import and the code in GET DATA /TYPE=TXT that implemented the
    eventual import.  This commit unifies the two parsers, dropping the one
    that was used only for preview.  This should prevent further discrepancies.
    Bug #61809.
    Thanks to Friedrich Beckmann for reporting this bug.

commit 4f3cf328723cf70c06702904e85768d6601918a2
Author: Ben Pfaff <>
Date:   Fri May 27 17:15:02 2022 -0700

    data-parser: Make data parser not require a dictionary.
    An upcoming commit will make the GUI's text import use this code too, in
    a context where a dictionary isn't yet available.  The data parser only
    uses the dictionary for one specific purpose that isn't relevant for the
    GUI, so remove the need for it.

commit 66c5538861e0e29333b1b0ee83ea2c548c08fd8f
Author: Ben Pfaff <>
Date:   Fri May 27 15:37:10 2022 -0700

    gui: Make text import assistant accept only one quote character.
    This aligns with what SPSS does.

commit a0ee1f3ba1dd37945983ea651c98b49b318d3e2f
Author: Ben Pfaff <>
Date:   Fri May 27 14:38:58 2022 -0700

    gui: Always use the most comma text import settings.
    The heuristic did not perform well in practice according to user reports,
    and most files use the defaults.

commit 9942b071bb615a4133d6edce68d79eb0538e9819
Author: Ben Pfaff <>
Date:   Fri May 27 12:55:47 2022 -0700

    gui: Honor quotes in the text data import dialog.
    The text data import dialog's preview of the data to be read
    didn't honor the quotes but always treated " and ' and (weirdly)
    parentheses as quotes.  This makes it honor the user's settings.
    Bug #61809.
    Thanks for Friedrich Beckmann for reporting this bug.


Summary of changes:
 src/language/data-io/data-list.c      |   7 +-
 src/language/data-io/data-parser.c    | 191 ++++++++++++++++++-----------
 src/language/data-io/data-parser.h    |   9 +-
 src/language/data-io/get-data.c       |   2 +-
 src/ui/gui/psppire-delimited-text.c   | 220 +++++++++++++---------------------
 src/ui/gui/psppire-delimited-text.h   |   9 +-
 src/ui/gui/psppire-import-assistant.h |   7 +-
 src/ui/gui/psppire-import-textfile.c  | 208 ++++++++++----------------------
 src/ui/gui/text-data-import.ui        | 109 ++++++++++++-----
 9 files changed, 369 insertions(+), 393 deletions(-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]