[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #5672] Yet more procedure / dictionary changes.

From: Ben Pfaff
Subject: [patch #5672] Yet more procedure / dictionary changes.
Date: Tue, 09 Jan 2007 22:50:16 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1) Gecko/20061024 Iceweasel/2.0 (Debian-2.0+dfsg-1)

Follow-up Comment #1, patch #5672 (project pspp):

The change to dict_delete_var worries me: now the callback will be called
with the vardict indexes wrong, because variables have been moved around in
the vars array but their indexes have not been updated in the vardicts.  This
means that some operations on variables will assert-fail (anything that
asserts on dict_contains_var, for example) if called within the callback. 
Seems worrisome given the stated purpose of this change.

Otherwise fine by me.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]