[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #5704] Data New/Open/Save

From: Ben Pfaff
Subject: [patch #5704] Data New/Open/Save
Date: Tue, 23 Jan 2007 17:16:44 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20061205 Iceweasel/ (Debian-

Update of patch #5704 (project pspp):

                  Status:   Ready For Test/Review => Works For Me           
             Assigned to:                     blp => jmd                    


Follow-up Comment #1:

I'd suggest adding a function, analogous to the "quote" function in gnulib,
that returns its argument as a quoted string in syntax format.  It could
return it in single quotes if it doesn't contain a single quote, in double
quotes if it doesn't contain a double quote, or in single quotes with doubled
single quotes otherwise.  If we don't do something like this, then we end up
with little ticking time bombs of code like this:

+      sss = create_syntax_string_source ("EXPORT OUTFILE='%s'.",
+                                        de->file_name);

Otherwise, looks good.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]