[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[patch #5874] Automatically add long name table.
From: |
Ben Pfaff |
Subject: |
[patch #5874] Automatically add long name table. |
Date: |
Thu, 19 Apr 2007 15:15:01 +0000 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.1) Gecko/20061205 Iceweasel/2.0.0.1 (Debian-2.0.0.1+dfsg-1) |
Update of patch #5874 (project pspp):
Status: Ready For Test/Review => Works For Me
_______________________________________________________
Follow-up Comment #1:
Looks good. A few nits:
It might be slightly clearer to write:
strcpy (long_name, short_name);
str_lowercase (long_name);
I wonder whether we should add a dictionary function to set both long and
short names at the same time. It would avoid the need to duplicate the long
comment, for one.
In the future please consider using "cvs -q diff". It makes patches slightly
easier to read by dropping all the "? unknown/file/name" lines.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?5874>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/