[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #6405] Make multiple error messages display in a single dialog

From: Ben Pfaff
Subject: [patch #6405] Make multiple error messages display in a single dialog
Date: Wed, 06 Feb 2008 16:29:57 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20071128 Iceweasel/ (Debian-

Follow-up Comment #2, patch #6405 (project pspp):

Wow, I'm glad you're paying attention.  I'm going to apply all of your
suggestions, except that I have a few follow-up comments:

>The condition of this if statement is always false, since 
>get_widget_assert, asserts that its return value is non NULL 

Well, sort of.  I actually tested this path, and if there's no widget named
"message", it just to use_fallback.  get_widget_assert doesn't assert, really,
it calls g_critical(), which by default just prints a message.

>Why do we have to drop any of the messages? They're in a scrolled 
>window, so the can all be viewed easily. If there's a huge number,
>then we could have two GtkTextArea widgets in a GtkvPaned, one 
>defaulting to the top, the other to the bottom of the textbuffer. 

The problem is that the amount of memory that could be consumed that way is
unlimited.  We support reading data files of unbounded size.  If each input
line produces an error, and we store each of those errors in memory, then we
will eventually run out of memory.

If there's a good way to display the contents of a text file of unbounded
size, we could use a file.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]