[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #6426] Patches needed for text import

From: John Darrington
Subject: [patch #6426] Patches needed for text import
Date: Mon, 18 Feb 2008 09:09:19 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20061205 Iceweasel/ (Debian-

Follow-up Comment #1, patch #6426 (project pspp):

The var-sheet-add-features.patch is going to conflict badly with some edits
I'm working on.  Can you hold off on this one for a day or two.  I'll try to
post a patch shortly and we can negotiate this.

In var-store-add-features, I suggest that instead of a "for-input" property
of boolean type, you use g_param_spec_enum to create a enumerated type
property called "format-type" or something similar.
Instead of the declarations :
  int trailing_rows;
  bool for_input;

can you write:

 gint trailing_rows;
 gboolean for_input;

I can't foresee any problems with any of the other patches.


Reply to this item at:


  Message sent via/by Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]