pspp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #6358] Text import


From: Ben Pfaff
Subject: [patch #6358] Text import
Date: Sun, 16 Mar 2008 19:58:24 +0000
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.1) Gecko/20061205 Iceweasel/2.0.0.1 (Debian-2.0.0.1+dfsg-1)

Follow-up Comment #23, patch #6358 (project pspp):

Thanks.  I applied all your suggested changes, except:

>...[in the separators array], shouldn't we use N_("") for the first element?


The first element is a widget name that gets passed to get_widget_assert, so
no.

>A number of places which use xstrdup, we can use g_strdup instead.
>Similarly they can be freed with g_free.

I can see that that is equivalent in some cases here, but I don't see the
benefit to changing it.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?6358>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]