[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[patch #6632] Translator for calculating ranks
|
From: |
Ben Pfaff |
|
Subject: |
[patch #6632] Translator for calculating ranks |
|
Date: |
Sun, 14 Sep 2008 19:28:17 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.1) Gecko/20061205 Iceweasel/2.0.0.1 (Debian-2.0.0.1+dfsg-1) |
Follow-up Comment #1, patch #6632 (project pspp):
I skimmed the code and it looked good.
The comment on casereader_create_append_rank() should really say how the
ranks are calculated. Are they in ascending order starting from 1, for
example?
There is no validation that the weight variable is nonnegative.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/patch/?6632>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/