pspp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Possible Bug in Makefile


From: Ben Pfaff
Subject: Re: Possible Bug in Makefile
Date: Thu, 02 Oct 2008 07:22:34 -0700
User-agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux)

John Darrington <address@hidden> writes:

> --- a/src/language/lexer/automake.mk
> +++ b/src/language/lexer/automake.mk
> @@ -17,7 +17,7 @@ EXTRA_DIST += src/language/lexer/q2c.c
>  
>  src/language/lexer/q2c$(EXEEXT_FOR_BUILD): 
> $(top_srcdir)/src/language/lexer/q2c.c 
>       @$(MKDIR_P) `dirname address@hidden
> -     $(CC_FOR_BUILD) $(top_srcdir)/src/language/lexer/q2c.c -o 
> $(top_builddir)/src/language/lexer/q2c
> +     $(CC_FOR_BUILD) $(top_srcdir)/src/language/lexer/q2c.c -o $@

It's better to write src/language/lexer/q2c$(EXEEXT_FOR_BUILD)
here than to write $@, because non-GNU makes do not necessarily
support $@ other than in implicit rules.  We do depend on some
GNU make features elsewhere, but I'd prefer to keep the
dependencies to a minimum so that we have a better chance of
being able to eliminate them one day.
-- 
"I admire him, I frankly confess it; and when his time comes
 I shall buy a piece of the rope for a keepsake."
--Mark Twain




reply via email to

[Prev in Thread] Current Thread [Next in Thread]