[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 9/9] sys-file-reader: Add tests.
From: |
Ben Pfaff |
Subject: |
Re: [PATCH 9/9] sys-file-reader: Add tests. |
Date: |
Sun, 30 Jan 2011 21:02:02 -0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) |
I added the following additional change to make understanding the
code a little easier:
diff --git a/tests/data/sack.c b/tests/data/sack.c
index ace153c..a5550a7 100644
--- a/tests/data/sack.c
+++ b/tests/data/sack.c
@@ -284,6 +284,12 @@ stdout. A data item is one of the following\n\
optionally followed by an asterisk and a positive integer, which\n\
specifies a repeat count for the data item.\n\
\n\
+Comments are introduced by # (outside a quoted string) and continue\n\
+to the end of the line. The characters > and < are also treated as\n\
+comments; the negative tests in the testsuite use these to point out\n\
+the parts of input that are actually invalid; e.g. >>4<< if the number\n\
+4 is invalid input.\n\
+\n\
The md5sum of the data written to stdout is written to stderr as\n\
16 hexadecimal digits followed by a new-line.\n",
program_name, program_name);
diff --git a/tests/data/sys-file-reader.at b/tests/data/sys-file-reader.at
index c204a55..6f8e8fb 100644
--- a/tests/data/sys-file-reader.at
+++ b/tests/data/sys-file-reader.at
@@ -1,3 +1,6 @@
+dnl Read the output of "sack --help" to understand the input files
+dnl used in these tests.
+
AT_BANNER([system file reader - positive])
AT_SETUP([variable labels and missing values])
--
Ben Pfaff
http://benpfaff.org
- [PATCH 0/9] sys-file-reader fixes and tests, Ben Pfaff, 2011/01/30
- [PATCH 3/9] sys-file-reader: Check that multiple response set names begin with `$'., Ben Pfaff, 2011/01/30
- [PATCH 2/9] sys-file-reader: Fix double-free on read of partial record., Ben Pfaff, 2011/01/30
- [PATCH 7/9] sys-file-reader: Avoid redundant "within system file" in messages., Ben Pfaff, 2011/01/30
- [PATCH 4/9] sys-file-reader: Add missing periods at end of error messages., Ben Pfaff, 2011/01/30
- [PATCH 6/9] sys-file-reader: Improve debugging usefulness of error messages., Ben Pfaff, 2011/01/30
- [PATCH 1/9] hash-functions: Use C instead of preprocessor to test size of double., Ben Pfaff, 2011/01/30
- [PATCH 5/9] sys-file-reader: Really enable warnings for invalid variable formats., Ben Pfaff, 2011/01/30
- [PATCH 8/9] sys-file-reader: Elevate invalid number of labels from warning to error., Ben Pfaff, 2011/01/30
- [PATCH 9/9] sys-file-reader: Add tests., Ben Pfaff, 2011/01/30
- Re: [PATCH 9/9] sys-file-reader: Add tests.,
Ben Pfaff <=