[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[VAR_NAME_LEN 12/17] variable-parser: Drop VAR_NAME_LEN restriction from

From: Ben Pfaff
Subject: [VAR_NAME_LEN 12/17] variable-parser: Drop VAR_NAME_LEN restriction from var_set_lookup_var_idx().
Date: Sat, 5 Feb 2011 13:25:54 -0800

This restriction is purely artificial, as part of an assertion.  Since
longer variable names are going to have to be supported, remove it.

Most uses of VAR_NAME_LEN within PSPP are wrong due to encoding issues:
the limit applies to variable names in the encoding used by the data
set, but most uses of VAR_NAME_LEN actually limit the length of a name
in UTF-8.  The UTF-8 representation of a name can be longer or shorter
than its representation in the data set encoding, so it seems best to
eliminate references to VAR_NAME_LEN entirely.
 src/language/lexer/variable-parser.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/src/language/lexer/variable-parser.c 
index 0cefb5d..84cf972 100644
--- a/src/language/lexer/variable-parser.c
+++ b/src/language/lexer/variable-parser.c
@@ -709,7 +709,6 @@ var_set_lookup_var_idx (const struct var_set *vs, const 
char *name,
   assert (vs != NULL);
   assert (name != NULL);
-  assert (strlen (name) <= VAR_NAME_LEN);
   return vs->lookup_var_idx (vs, name, idx);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]