Re: [PATCH 03/13] gui: Add undocumented --measure-startup option.

[John Darrington]

On Mon, Apr 16, 2012 at 08:52:09PM -0700, Ben Pfaff wrote:
     This is useful for testing the effects of code changes upon the
     time required to start PSPPIRE.
     ---
      src/ui/gui/main.c |   37 ++++++++++++++++++++++++++++++++++---
      1 files changed, 34 insertions(+), 3 deletions(-)
     
     diff --git a/src/ui/gui/main.c b/src/ui/gui/main.c
     index bb8f19d..eea71f8 100644
     --- a/src/ui/gui/main.c
     +++ b/src/ui/gui/main.c
      
     @@ -196,9 +216,17 @@ static gboolean
      run_inner_loop (gpointer data)
      {
        struct initialisation_parameters *ip = data;
     +  GSource *source;
     +  guint id;
     +
        initialize (ip->data_file);
      
     -  g_timeout_add (500, hide_splash_window, ip->splash_window);
     +  source = g_idle_source_new ();
     +
     +  g_source_set_priority (source, G_PRIORITY_LOW);
     +  g_source_set_callback (source, hide_splash_window, ip->splash_window, 
NULL);
     +  id = g_source_attach (source, NULL);
     +  g_source_unref (source);
      

I haven't tried this patch, but I'm concerned that it seems to change then 
behaviour 
of the splash window.  The way it was designed was to appear as soon as it can, 
and
stay on the screen for as long as it takes to run the initialize 
function, plus half a second.  This change seems to make it disappear 
immediately
after initialize returns, which is fine on a slow machine, but on a fast one, 
could make it flash too quick to see, which might alarm users.
      

-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://keys.gnupg.net or any PGP keyserver for public key.

signature.asc
Description: Digital signature