[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 11/17] pspp-widget-facade: New code to measure and render som
From: |
Ben Pfaff |
Subject: |
Re: [PATCH 11/17] pspp-widget-facade: New code to measure and render some GTK+ widgets. |
Date: |
Mon, 23 Apr 2012 22:43:28 -0700 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) |
John Darrington <address@hidden> writes:
> On Sun, Apr 22, 2012 at 11:12:29AM -0700, Ben Pfaff wrote:
> +
> + va_start (args, type1);
> + for (type = final_type = type1; type != 0; type = va_arg (args,
> GType))
> + {
> + const gchar *type_name = g_type_name (type);
> + g_string_append_printf (&path, ".%s", type_name);
> + g_string_append_printf (&class_path, ".%s", type_name);
> + final_type = type;
> + }
> +
> + style = gtk_rc_get_style_by_paths (gtk_widget_get_settings (base),
> + path.str, class_path.str,
> final_type);
>
>
> There does not appear to be a va_end closing this va_start.
Thanks, I added one just after the loop.
- [PATCH 05/17] pspp-sheet-view: Fix rendering moving cursor left or right with keyboard., (continued)
- [PATCH 05/17] pspp-sheet-view: Fix rendering moving cursor left or right with keyboard., Ben Pfaff, 2012/04/22
- [PATCH 06/17] pspp-sheet-view-column: Add support for tooltips on columns., Ben Pfaff, 2012/04/22
- [PATCH 07/17] pspp-sheet-view: Edit cells on the first click by default., Ben Pfaff, 2012/04/22
- [PATCH 09/17] pspp-sheet-view: Start editing upon button release, not press., Ben Pfaff, 2012/04/22
- [PATCH 10/17] pspp-sheet-view: Add "special-cells" property to speed drawing many columns., Ben Pfaff, 2012/04/22
- [PATCH 13/17] pspp-sheet-view: Improve look of sheet when there are few columns., Ben Pfaff, 2012/04/22
- [PATCH 11/17] pspp-widget-facade: New code to measure and render some GTK+ widgets., Ben Pfaff, 2012/04/22
- [PATCH 14/17] pspp-sheet-view: Make pspp_sheet_view_stop_editing() public., Ben Pfaff, 2012/04/22
- [PATCH 08/17] pspp-sheet-view: Support rectangular selection, column popup menus., Ben Pfaff, 2012/04/22
- [PATCH 12/17] pspp-sheet-view: Optimize by making column header widgets lazy., Ben Pfaff, 2012/04/22
- [PATCH 15/17] pspp-sheet-view: Add "fixed-height" and "fixed-height-set" properties., Ben Pfaff, 2012/04/22
- [PATCH 17/17] psppire-cell-renderer-button: Add "slash" property., Ben Pfaff, 2012/04/22
- [PATCH 16/17] psppire-cell-renderer-button: New cell renderer for GtkButton., Ben Pfaff, 2012/04/22