[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Windows truncating data - Bug in src/libpspp/ext-array.c
From: |
Ben Pfaff |
Subject: |
Re: Windows truncating data - Bug in src/libpspp/ext-array.c |
Date: |
Wed, 13 Jun 2012 07:44:19 -0700 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) |
John Darrington <address@hidden> writes:
> So it would seem that it is unsafe (even on GNU/Linux) not to seek (or flush)
> before switching between reading and writing.
>
> I sent Harry a patch which basically disabled this optimisation completely,
> and
> Henry's report suggested that this fixed the problem, but caused the operation
> to take a lot longer to run (not suprising). I suggest that the correct fix
> should involve a flag in the ext_array struct which records the direction of
> the most recent operation (read or write) and ensures that the seek is always
> done if the direction has changed.
Wow, good detective work.
Yes, that sounds like a good solution to me.