pspp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 4/4] psppire-data-window: Delete dataset when closing window.


From: John Darrington
Subject: Re: [PATCH 4/4] psppire-data-window: Delete dataset when closing window.
Date: Sun, 8 Jul 2012 07:21:53 +0000
User-agent: Mutt/1.5.18 (2008-05-17)

On Sat, Jul 07, 2012 at 11:49:16PM -0700, Ben Pfaff wrote: 

     The code added to psppire_data_window_dispose() in this commit
     should probably go in a "finalize" function instead but there seems
     to be a separate problem with references to PsppireVarSheet such
     that if this new code is in "finalize" then dataset_destroy() will
     call dict_clear() which will invoke the callbacks for PsppireDict
     which will try to access the destroyed window.

Your description seems to suggest to me, that either PsppireDict should 
keep a reference to the window, or the callbacks should be disconnected
or rendered safe when the window is destroyed.

J'


-- 
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://keys.gnupg.net or any PGP keyserver for public key.

Attachment: signature.asc
Description: Digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]