pspp-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: commit message formatting


From: Friedrich Beckmann
Subject: Re: commit message formatting
Date: Sun, 31 May 2015 01:04:16 +0200

Hi Ben,

thanks for the hint. 

Friedrich

Am 31.05.2015 um 01:00 schrieb Ben Pfaff <address@hidden>:

Hi Friedrich.  Thanks for all the work you've been doing on PSPP lately.

I noticed that the commit messages you're putting into the repository
are single very long lines, like this:

   fixed initial show of names in header window. Variable names only showed up after switching between variable and data window. The reason is that the buttons of the columns are not created. This is due to interdependency between the size allocation and the button creation. I removed the need_button mechanism.

The canonical way to format Git commit messages is with a brief,
single-line summary paragraph, followed by one or more paragraphs with
additional explanation, wrapped at about 75 or so columns.  You can find
lots of examples of those in the repository, but here's one way that I
might format the above according to the usual fashion:

   gui: Fix initial show of names in header window.

   The Variable names only showed up after switching between variable and
   data window. The reason is that the buttons of the columns are not
   created. This is due to interdependency between the size allocation and
   the button creation. I removed the need_button mechanism.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]