Re: [Qemu-arm] [PATCH v2 7/7] hw/arm/sysbus-fdt: remove qemu_fdt_setprop returned value check

[Eric Auger]

Hi David,
On 01/11/2016 03:45 AM, David Gibson wrote:
> On Wed, Jan 06, 2016 at 03:13:25PM +0000, Eric Auger wrote:
>> qemu_fdt_setprop self-exists in case of error hence no need to check
>> the returned value.
>>
>> Signed-off-by: Eric Auger <address@hidden>
> 
> This change is fine, but in general I'm disinclined to invest too much
> in the qemu interfaces for manipulating flattened trees.
> 
> I think our device tree manipulation in qemu is now complicated enough
> that we should move towards using an unflattened (i.e. pointer based)
> DT representation inside qemu, which is generally more suitable for
> complex manipulation.
OK. Is there any user-space library available for un-flattened tree
manipulation? I only found references to kernel unflattened tree
manipulations (drivers/of/fdt.c, include/linux/of.h) and dtc flattree.c.

Besides the indicated direction do I understand correctly that you do
not reject the series?

Best Regards

Eric
> 
> That would then get flattened into a blob for the guest in a single
> pass at reset time.
>