Re: [Qemu-arm] [RFC 6/7] hw: arm: virt: register reserved IOVA region

[Peter Maydell]

On 27 January 2016 at 13:51, Eric Auger <address@hidden> wrote:
> Registers a 16x64kB reserved iova region. Currently this iova
> region is used by the kernel to map host MSI controller frames
> (GICv2m, GITS_TRANSLATER).

Do you mean the host kernel or the guest kernel? The host
kernel should be keeping its paws out of the guest's
address space, and the guest kernel can manage the memory
and the address space any way it likes, I would have thought.
It's not clear to me what this is for.

> Signed-off-by: Eric Auger <address@hidden>
> ---
>  hw/arm/virt.c         | 10 ++++++++++
>  include/hw/arm/virt.h |  1 +
>  2 files changed, 11 insertions(+)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 3839c68..7eaf8be 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -125,6 +125,7 @@ static const MemMapEntry a15memmap[] = {
>      [VIRT_GPIO] =               { 0x09030000, 0x00001000 },
>      [VIRT_SECURE_UART] =        { 0x09040000, 0x00001000 },
>      [VIRT_MMIO] =               { 0x0a000000, 0x00000200 },
> +    [VIRT_RESERVED] =           { 0x0be00000, 0x00100000 },
>      /* ...repeating for a total of NUM_VIRTIO_TRANSPORTS, each of that size 
> */

You've put the new entry between the VIRT_MMIO line and the comment that
is associated with it.

thanks
-- PMM