[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH 3/4] target-arm: Combine user-only and softmmu get

From: Sergey Fedorov
Subject: Re: [Qemu-arm] [PATCH 3/4] target-arm: Combine user-only and softmmu get/set_r13_banked()
Date: Fri, 12 Feb 2016 18:48:44 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1

On 12.02.2016 18:16, Edgar E. Iglesias wrote:
> On Fri, Feb 12, 2016 at 03:15:22PM +0000, Peter Maydell wrote:
>> On 12 February 2016 at 15:12, Edgar E. Iglesias
>> <address@hidden> wrote:
>>> On Thu, Feb 11, 2016 at 07:11:48PM +0000, Peter Maydell wrote:
>>>> The user-mode versions of get/set_r13_banked() exist just to assert
>>>> if they're ever called -- the translate time code should never
>>>> emit calls to them because SRS from user mode always UNDEF.
>>>> There's no code in the softmmu versions that can't compile in
>>>> CONFIG_USER_ONLY, so combine the two functions rather than
>>>> having completely split versions under ifdefs.
>>>> Signed-off-by: Peter Maydell <address@hidden>
>>> Hi Peter,
>>> Do we really need the assert?
>>> If we keep it, can't we have it for both -user and -softmmu (avoiding the 
>>> ifdef)?
>> I would be happy to entirely drop the assert, yes.
> OK, thanks.
> With that change:
> Reviewed-by: Edgar E. Iglesias <address@hidden>

Yes, I also think it would be okay to drop that assert. Anyway:

Reviewed-by: Sergey Fedorov <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]