[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH v4 9/9] hw/timer: QOM'ify tusb6010

From: hitmoon
Subject: Re: [Qemu-arm] [PATCH v4 9/9] hw/timer: QOM'ify tusb6010
Date: Mon, 22 Feb 2016 17:20:23 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0

在 2016年02月22日 17:18, Peter Maydell 写道:
On 22 February 2016 at 03:15, xiaoqiang zhao <address@hidden> wrote:
Move majority of old SysBus init's work the into instance_init.

musb_init must be called in SysBus's init, otherwise it will
break "make check" with error message as follows:

qom/object.c:1576:object_get_canonical_path_component: assertion failed: 
(obj->parent != NULL)

Signed-off-by: xiaoqiang zhao <address@hidden>
  hw/timer/tusb6010.c | 23 ++++++++++++++++-------
  1 file changed, 16 insertions(+), 7 deletions(-)
Devices should either be instance_init + realize, or
sysbus-init. This patch would make this device be a mix
of both. You should just drop this patch until musb has
been properly QOMified.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]