[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v4 7/9] target-mips: Add abs2008 flavor of <ABS|NE
From: |
Leon Alrae |
Subject: |
Re: [Qemu-arm] [PATCH v4 7/9] target-mips: Add abs2008 flavor of <ABS|NEG>.<S|D> |
Date: |
Thu, 14 Apr 2016 11:52:32 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 |
On 12/04/16 13:58, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <address@hidden>
>
> Updated handling of instuctions <ABS|NEG>.<S|D>. Note that legacy
> (pre-abs2008) ABS and NEG instructions are arithmetic (any NaN operand
> signals invalid operation), while abs2008 ones are non-arithmetic, always
> changing the sign bit, even for NaN-like operands. Details on these
> instructions are documented in [1] p. 35 and 359.
>
> [1] "MIPS® Architecture For Programmers Volume II-A:
> The MIPS64® Instruction Set Reference Manual",
> Imagination Technologies LTD, Revision 6.04, November 13, 2015
>
> Signed-off-by: Thomas Schwinge <address@hidden>
> Signed-off-by: Maciej W. Rozycki <address@hidden>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> ---
> target-mips/translate.c | 27 +++++++++++++++++++++++----
> 1 file changed, 23 insertions(+), 4 deletions(-)
>
> diff --git a/target-mips/translate.c b/target-mips/translate.c
> index de0b224..1d376fc 100644
> --- a/target-mips/translate.c
> +++ b/target-mips/translate.c
> @@ -1434,6 +1434,8 @@ typedef struct DisasContext {
> bool vp;
> bool cmgcr;
> bool mrp;
> + bool abs2008;
> +
Blank line. Otherwise:
Reviewed-by: Leon Alrae <address@hidden>
Regards,
Leon
- [Qemu-arm] [PATCH v4 3/9] softfloat: For Mips only, correct order in pickNaNMulAdd(), (continued)
- [Qemu-arm] [PATCH v4 3/9] softfloat: For Mips only, correct order in pickNaNMulAdd(), Aleksandar Markovic, 2016/04/12
- [Qemu-arm] [PATCH v4 6/9] target-mips: Activate IEEE 274-2008 support, Aleksandar Markovic, 2016/04/12
- [Qemu-arm] [PATCH v4 5/9] softfloat: Clean up white spaces in softfloat-specialize.h, Aleksandar Markovic, 2016/04/12
- [Qemu-arm] [PATCH v4 2/9] softfloat: For Mips only, correct default NaN values, Aleksandar Markovic, 2016/04/12
- [Qemu-arm] [PATCH v4 4/9] softfloat: Clean up hex constants capitalization in softfloat-specialize.h, Aleksandar Markovic, 2016/04/12
- [Qemu-arm] [PATCH v4 8/9] target-mips: Add nan2008 flavor of <CEIL|CVT|FLOOR|ROUND|TRUNC>.<L|W>.<S|D>, Aleksandar Markovic, 2016/04/12
- [Qemu-arm] [PATCH v4 7/9] target-mips: Add abs2008 flavor of <ABS|NEG>.<S|D>, Aleksandar Markovic, 2016/04/12
- Re: [Qemu-arm] [PATCH v4 7/9] target-mips: Add abs2008 flavor of <ABS|NEG>.<S|D>,
Leon Alrae <=
- [Qemu-arm] [PATCH v4 1/9] softfloat: Implement run-time-configurable meaning of signaling NaN bit, Aleksandar Markovic, 2016/04/12
- Re: [Qemu-arm] [PATCH v4 1/9] softfloat: Implement run-time-configurable meaning of signaling NaN bit, Leon Alrae, 2016/04/13
- Re: [Qemu-arm] [PATCH v4 1/9] softfloat: Implement run-time-configurable meaning of signaling NaN bit, Leon Alrae, 2016/04/14