[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 1/6] hw/char: QOM'ify pl011 model
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-arm] [PATCH 1/6] hw/char: QOM'ify pl011 model |
Date: |
Wed, 25 May 2016 15:15:16 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 |
On 25/05/2016 15:08, Peter Maydell wrote:
>> > /* AUX / UART1 */
>> > - /* TODO: don't call qemu_char_get_next_serial() here, instead set
>> > - * chardev properties for each uart at the board level, once pl011
>> > - * (uart0) has been updated to avoid qemu_char_get_next_serial()
>> > - */
> This comment says this should be fixed by having board-level
> properties; you've removed it but this patch isn't adding
> the properties to this (SoC-level) device. I think the board
> level should be looking at serial_hds[], not this code.
>
>> > @@ -310,8 +312,7 @@ static void pl011_class_init(ObjectClass *oc, void
>> > *data)
>> >
>> > dc->realize = pl011_realize;
>> > dc->vmsd = &vmstate_pl011;
>> > - /* Reason: realize() method uses qemu_char_get_next_serial() */
>> > - dc->cannot_instantiate_with_device_add_yet = true;
> Why does instantiating with device_add work now? There's
> still no way to wire up interrupt lines or map mmio regions.
> (This has never made much sense to me -- Markus?)
You can create it with -device if your board provides a platform bus and
there's an FDT creator function. If you don't, you get an error.
Regarding device_add, it's disabled anyway because sysbus is not
hotpluggable.
Eiter way it's safe to remove this line, which is for outliers that
otherwise would not give any error message.
Thanks,
Paolo
- [Qemu-arm] [PATCH 0/6] Drop the qemu_char_get_next_serial function, xiaoqiang zhao, 2016/05/25
- [Qemu-arm] [PATCH 3/6] hw/char: QOM'ify digic-uart model, xiaoqiang zhao, 2016/05/25
- [Qemu-arm] [PATCH 5/6] hw/char: QOM'ify xilinx_uartlite model, xiaoqiang zhao, 2016/05/25
- [Qemu-arm] [PATCH 1/6] hw/char: QOM'ify pl011 model, xiaoqiang zhao, 2016/05/25
- Re: [Qemu-arm] [Qemu-devel] [PATCH 1/6] hw/char: QOM'ify pl011 model, xiaoqiang zhao, 2016/05/26
- Re: [Qemu-arm] [Qemu-devel] [PATCH 1/6] hw/char: QOM'ify pl011 model, Peter Maydell, 2016/05/27
- Re: [Qemu-arm] [Qemu-devel] [PATCH 1/6] hw/char: QOM'ify pl011 model, Paolo Bonzini, 2016/05/27
- Re: [Qemu-arm] [Qemu-devel] [PATCH 1/6] hw/char: QOM'ify pl011 model, xiaoqiang zhao, 2016/05/27
- Re: [Qemu-arm] [Qemu-devel] [PATCH 1/6] hw/char: QOM'ify pl011 model, Markus Armbruster, 2016/05/30
[Qemu-arm] [PATCH 6/6] char: get rid of qemu_char_get_next_serial, xiaoqiang zhao, 2016/05/25
[Qemu-arm] [PATCH 4/6] hw/char: QOM'ify stm32f2xx_usart model, xiaoqiang zhao, 2016/05/25