[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH v4 2/3] hw/arm/virt: Add PMU node for virt machine

From: Peter Maydell
Subject: Re: [Qemu-arm] [PATCH v4 2/3] hw/arm/virt: Add PMU node for virt machine
Date: Mon, 6 Jun 2016 16:59:31 +0100

On 26 April 2016 at 12:40, Shannon Zhao <address@hidden> wrote:
> From: Shannon Zhao <address@hidden>
> Add a virtual PMU device for virt machine while use PPI 7 for PMU
> overflow interrupt number.
> Signed-off-by: Shannon Zhao <address@hidden>

> diff --git a/stubs/kvm.c b/stubs/kvm.c
> index ddd6204..667e269 100644
> --- a/stubs/kvm.c
> +++ b/stubs/kvm.c
> @@ -6,3 +6,8 @@ int kvm_arch_irqchip_create(MachineState *ms, KVMState *s)
>  {
>      return 0;
>  }
> +
> +int kvm_arm_pmu_create(CPUState *cs, int irq)
> +{
> +    return 0;
> +}

Hi. I'm afraid this breaks compilation on 32-bit ARM hosts:
for 32-bit ARM we don't have a real kvm_arm_pmu_create() so we
end up pulling in the stubs/kvm.o object file from the stub
library. Unfortunately that then means we have two versions of
kvm_arch_irqchip_create() and the linker refuses to link.

You need to split this stub function into its own .c file --
you can only share a .c file with another stub function if
it's always the case that a build either needs all the stubs
or none of them.

I've dropped the PMU series from target-arm.next.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]