[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH 1/2] Fix confusing argument names of do_unaligned_

From: Peter Maydell
Subject: Re: [Qemu-arm] [PATCH 1/2] Fix confusing argument names of do_unaligned_access() functions
Date: Fri, 10 Jun 2016 17:33:24 +0100

On 10 June 2016 at 17:26, Sergey Sorokin <address@hidden> wrote:
> There are functions cpu_unaligned_access() and do_unaligned_access() that
> are called with access type and mmu index arguments. But these arguments
> are named 'is_write' and 'is_user' in their declarations.
> The patch fixes the names to avoid a confusion.
> Signed-off-by: Sergey Sorokin <address@hidden>

If we're going to touch all of these then we have an enum type
we should be using instead of just 'int' for the old
is_write argument: MMUAccessType (defined in cpu-common.h).

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]