[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [Qemu-devel] [PATCH RFC 06/16] vl: move smp parsing to ma

From: Paolo Bonzini
Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH RFC 06/16] vl: move smp parsing to machine pre_init
Date: Tue, 14 Jun 2016 16:05:07 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0

On 14/06/2016 16:03, Andrew Jones wrote:
> However, I just chatted with Igor, and he says cpu hotplug operates
> on logical processors, and thus it's fine to talk about hotplugging
> threads. Even real hardware does this. Real hardware will plug a
> socket full of threads, but then the firmware may keep most of them
> disabled until they're "hotplugged". So, I think the value of cpus
> can be anything. Even the useless value of zero.

Fair enough!

> I'd keep =0 allowed. In most cases it just means =1, same as if the
> property wasn't input. In some cases, cpus,maxcpus it creates a
> useless machine, but maybe could accelerate QEMU runs for the purpose
> of probing? Eh, it probably adds more complication than necessary...
> Considering cpus should mean logical processors, I think that can
> have any value on (0, maxcpus]

Ok.  The machine can warn if necessary.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]