[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH] hw/intc/arm_gicv3: Fix compilation with simple tr
From: |
Sergey Fedorov |
Subject: |
Re: [Qemu-arm] [PATCH] hw/intc/arm_gicv3: Fix compilation with simple trace backend |
Date: |
Mon, 20 Jun 2016 13:22:26 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 |
On 20/06/16 12:57, Peter Maydell wrote:
> Fix missing includes of qemu/log.h, which broke compilation with the
> simple trace backend (the default backend pulls in log.h implicitly
> via trace.h).
>
> Signed-off-by: Peter Maydell <address@hidden>
Tested-by: Sergey Fedorov <address@hidden>
Reviewed-by: Sergey Fedorov <address@hidden>
Thanks,
Sergey
> ---
> In particular, this broke travis builds.
> ---
> hw/intc/arm_gicv3_dist.c | 1 +
> hw/intc/arm_gicv3_redist.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/hw/intc/arm_gicv3_dist.c b/hw/intc/arm_gicv3_dist.c
> index b977ae5..3ea3dd0 100644
> --- a/hw/intc/arm_gicv3_dist.c
> +++ b/hw/intc/arm_gicv3_dist.c
> @@ -10,6 +10,7 @@
> */
>
> #include "qemu/osdep.h"
> +#include "qemu/log.h"
> #include "trace.h"
> #include "gicv3_internal.h"
>
> diff --git a/hw/intc/arm_gicv3_redist.c b/hw/intc/arm_gicv3_redist.c
> index 55c25e8..2f60096 100644
> --- a/hw/intc/arm_gicv3_redist.c
> +++ b/hw/intc/arm_gicv3_redist.c
> @@ -10,6 +10,7 @@
> */
>
> #include "qemu/osdep.h"
> +#include "qemu/log.h"
> #include "trace.h"
> #include "gicv3_internal.h"
>