[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH 4/4] tests: add a m25p80 test

From: Peter Maydell
Subject: Re: [Qemu-arm] [PATCH 4/4] tests: add a m25p80 test
Date: Mon, 20 Jun 2016 16:43:35 +0100

On 17 June 2016 at 09:35, Cédric Le Goater <address@hidden> wrote:
> This test uses the palmetto platform and the AST2400 SPI controller to
> test the m25p80 flash module device model. The flash model is defined
> by the platform (n25q256a) and it would be nice to find way to control
> it, using a property probably.
> Signed-off-by: Cédric Le Goater <address@hidden>

> +/*
> + * QTest testcase for the M25P80 Flash (Using the AST2400 SPI Controller)
> + *
> + * Copyright (C) 2016 IBM Corp.

Should there be a signed-off-by from an IBM email address?

> +static char tmp_path[] = "/tmp/qtest.XXXXXX";

Can you make this "/tmp/qtest.m25p80.XXXXXX" so that we
know which test is at fault if files get left around?

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]