[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v9 00/10] IEEE 754-2008 support for Mips
From: |
Leon Alrae |
Subject: |
Re: [Qemu-arm] [PATCH v9 00/10] IEEE 754-2008 support for Mips |
Date: |
Thu, 23 Jun 2016 17:44:57 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Jun 23, 2016 at 04:46:14PM +0100, Peter Maydell wrote:
> On 10 June 2016 at 10:57, Aleksandar Markovic
> <address@hidden> wrote:
> > From: Aleksandar Markovic <address@hidden>
> >
> > This patch series provides number of IEEE 754-2008-related features to
> > Mips platform. It addresses the most sensitive changes that require
> > modification of SoftFloat library, also used by most other platforms.
> >
> > In order to make develpoment, testing, and integration easier, the patch
> > is split into two distinct parts:
> >
> > 1. Part 1 (patches 1/10, 2/10, 3/10, 4/10, 5/10) that does not change any
> > calculation or behavior on any platform (and, for that matter, even on
> > Mips platform). Its sole purpose is to address platform independant
> > issues in a non-invasive manner, and to make Part 2 possible.
> >
> > 2. Part 2 (patches 6/10, 7/10, 8/10, 9/10, 10/10) that sets some Mips
> > processors to use provisions from Part 1, and additionally implements
> > number of IEEE 754-2008-related features for Mips, while, at the same
> > time, mainly dealing with files located in directory target-mips only.
>
> Hi. I've reviewed the patches in Part 1, and I'm happy with them
> apart from a few trivial things. I'm not going to look at Part 2
> since it's pretty MIPS specific.
>
> I'm assuming that Leon will take these via the MIPS tree. Leon,
> it's up to you whether you're happy to fix up the minor things I
> raised when you put the patches into your tree or if you'd
> prefer to have Aleksandar respin and resend the patchset.
No need to respin; I'll fix these issues while applying to target-mips
queue.
> Either way, it would be good to get these into a pull request
> by Monday since softfreeze deadline is nearly here...
Sure, I'll send the pullreq by then.
Thanks,
Leon