[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH v2] Fix confusing argument names in some common fu

From: Peter Maydell
Subject: Re: [Qemu-arm] [PATCH v2] Fix confusing argument names in some common functions
Date: Tue, 12 Jul 2016 13:58:14 +0100

On 14 June 2016 at 13:26, Sergey Sorokin <address@hidden> wrote:
> There are functions tlb_fill(), cpu_unaligned_access() and
> do_unaligned_access() that are called with access type and mmu index
> arguments. But these arguments are named 'is_write' and 'is_user' in their
> declarations. The patches fix the arguments to avoid a confusion.
> Signed-off-by: Sergey Sorokin <address@hidden>
> ---
> In the second version of the patch a type of access_type argument
> was changed from int to MMUAccessType. To allow it the declaration of
> MMUAccessType was moved from exec/cpu-common.h into qom/cpu.h
> The series of two patches was merged into one.

Applied to master, thanks.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]