[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [Qemu-devel] [PATCH RFC 04/16] hw/core/machine: Introduce

From: Eduardo Habkost
Subject: Re: [Qemu-arm] [Qemu-devel] [PATCH RFC 04/16] hw/core/machine: Introduce pre_init
Date: Thu, 14 Jul 2016 17:10:47 -0300
User-agent: Mutt/1.6.1 (2016-04-27)

On Tue, Jun 14, 2016 at 07:58:56AM +0200, Andrew Jones wrote:
> On Tue, Jun 14, 2016 at 11:30:37AM +1000, David Gibson wrote:
> > On Fri, Jun 10, 2016 at 07:40:15PM +0200, Andrew Jones wrote:
> > > From: Igor Mammedov <address@hidden>
> > > 
> > > Signed-off-by: Igor Mammedov <address@hidden>
> > > Signed-off-by: Andrew Jones <address@hidden>
> > 
> > I think this needs some kind of rationale.
> > 
> > Since with this patch it is called immediately before ->init, I'm not
> > really seeing the point of this.
> Many machines already override ->init, so if we want to move code
> from vl.c into machine methods, but be sure that they run it now,
> then we have to invent a pre-init. I (or Igor) can add something
> like that to the commit message for the next round.

If we just want to move vl.c code into machine, why not just
create a simple machine_pre_init() function?

We can add a virtual method that can be reimplemented by
subclasses later, only when we really see the need for a subclass
to override some behavior.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]