[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH 6/6] arm: add support for an ast2500 evaluation bo
Cédric Le Goater
Re: [Qemu-arm] [PATCH 6/6] arm: add support for an ast2500 evaluation board
Thu, 28 Jul 2016 16:26:31 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0
On 07/28/2016 10:03 AM, Cédric Le Goater wrote:
> On 07/28/2016 09:58 AM, Andrew Jeffery wrote:
>> On Thu, 2016-07-28 at 09:15 +0200, Cédric Le Goater wrote:
>>>> Also, the meaning of the bits have changed from the AST2400 - they
>>>> probably should be documented somewhere?
>>> So you want me send to an updated version of :
>>> as a prereq ?
>> I mentioned this in passing due to the discussion on my original patch.
>> I think we discussed this separately and concluded the macros were
>> pretty verbose given they are sort-of single-use given the value
>> doesn't change. Maybe just comments as Peter was requesting? You have
>> the patch below but some of the macros will be different for the
>> I'm probably leaning towards comments over macros, but don't feel
>> strongly either way.
> ok. having a correct value is a minimum and this is not the case
> in this patch. I think I will go for the comments for now as We
> have not merged anything in mainline uboot yet.
I gave comments a try and honestly, macros are cleaner to check
which bits you are setting. less prone to errors. So I will send
a v2 with macros.
- [Qemu-arm] [PATCH 3/6] ast2400: use machine cpu_model to initialize the soc cpu, (continued)