[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v3 06/10] palmetto-bmc: add board specific configu
From: |
Peter Maydell |
Subject: |
Re: [Qemu-arm] [PATCH v3 06/10] palmetto-bmc: add board specific configuration |
Date: |
Thu, 11 Aug 2016 11:27:51 +0100 |
On 2 August 2016 at 18:15, Cédric Le Goater <address@hidden> wrote:
> aspeed_board_init() now uses a board identifier to customize some values
> specific to the board.
>
> Signed-off-by: Cédric Le Goater <address@hidden>
> ---
>
> Changes since v2:
>
> - removed silicon-rev and cpu-model. This is now in the SoC.
>
> Changes since v1:
>
> - changed aspeed_init() prototype to use a 'const AspeedBoardConfig *'
> - fixed white space issues
>
> hw/arm/aspeed.c | 22 ++++++++++++++++++----
> 1 file changed, 18 insertions(+), 4 deletions(-)
>
> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
> index ad0a062b5624..4226b8dcd95c 100644
> --- a/hw/arm/aspeed.c
> +++ b/hw/arm/aspeed.c
> @@ -30,6 +30,19 @@ typedef struct AspeedBoardState {
> MemoryRegion ram;
> } AspeedBoardState;
>
> +typedef struct AspeedBoardConfig {
> + const char *soc_name;
> + uint32_t hw_strap1;
> +} AspeedBoardConfig;
> +
> +enum {
> + PALMETTO_BMC
Since you need to respin this set anyway, I shall pick a nit:
a trailing comma here would be preferable because then you
don't need to change the line when you add the next entry
to the enum.
Otherwise
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- Re: [Qemu-arm] [PATCH v3 03/10] aspeed-soc: provide a framework to add new SoCs, (continued)
[Qemu-arm] [PATCH v3 04/10] palmetto-bmc: rename the Aspeed board file to aspeed.c, Cédric Le Goater, 2016/08/02
[Qemu-arm] [PATCH v3 05/10] palmetto-bmc: replace palmetto_bmc with aspeed, Cédric Le Goater, 2016/08/02
[Qemu-arm] [PATCH v3 06/10] palmetto-bmc: add board specific configuration, Cédric Le Goater, 2016/08/02
[Qemu-arm] [PATCH v3 07/10] hw/misc: use macros to define hw-strap1 register on the AST2400 Aspeed SoC, Cédric Le Goater, 2016/08/02
[Qemu-arm] [PATCH v3 08/10] aspeed: add a AST2500 SoC and support to the SCU and SDMC controllers controllers, Cédric Le Goater, 2016/08/02
[Qemu-arm] [PATCH v3 09/10] arm: add support for an ast2500 evaluation board, Cédric Le Goater, 2016/08/02