Re: [Qemu-arm] [PATCH] block: m25p80c Fix vmstate structure name

[Peter Maydell]

On 19 August 2016 at 13:30,  <address@hidden> wrote:
> From: Marcin Krzeminski <address@hidden>
>
> Change wrong name of the vmstate structure. Since this breaks
> compatibility update version and fields to 0.
>
> Signed-off-by: Marcin Krzeminski <address@hidden>
> ---
>
> This patch assumes that none migrates m25p80 flash devices.
>
>  hw/block/m25p80.c | 29 ++++++++++++++---------------
>  1 file changed, 14 insertions(+), 15 deletions(-)
>
> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
> index 9828ee6..d29ff4c 100644
> --- a/hw/block/m25p80.c
> +++ b/hw/block/m25p80.c
> @@ -1189,9 +1189,9 @@ static Property m25p80_properties[] = {
>  };
>
>  static const VMStateDescription vmstate_m25p80 = {
> -    .name = "xilinx_spi",
> -    .version_id = 3,
> -    .minimum_version_id = 1,
> +    .name = "m25p80",
> +    .version_id = 0,
> +    .minimum_version_id = 0,
>      .pre_save = m25p80_pre_save,

Are you sure that the name is part of the on-the-wire state?
I thought it wasn't, in which case this doesn't even need a
version bump, much less a version-reset-to-zero. But I could
be wrong. David, Juan, Amit?

thanks
-- PMM