[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [PATCH v3 2/2] ARM: Virt: ACPI: Build an IORT table with
Re: [Qemu-arm] [PATCH v3 2/2] ARM: Virt: ACPI: Build an IORT table with RC and ITS nodes
Mon, 24 Oct 2016 13:29:42 +0100
On 17 October 2016 at 15:07, Andrew Jones <address@hidden> wrote:
> On Mon, Oct 17, 2016 at 02:31:06PM +0200, Eric Auger wrote:
>> From: Prem Mallappa <address@hidden>
>> This patch builds an IORT table that features a root complex node and
>> an ITS node. This complements the ITS description in the ACPI MADT
>> table and allows vhost-net on ACPI guest.
>> Signed-off-by: Prem Mallappa <address@hidden>
>> Signed-off-by: Eric Auger <address@hidden>
>> @@ -667,17 +722,6 @@ void virt_acpi_build(VirtGuestInfo *guest_info,
>> AcpiBuildTables *tables)
>> ACPI_BUILD_TABLE_FILE, tables_blob,
>> 64, false /* high memory */);
>> - /*
>> - * The ACPI v5.1 tables for Hardware-reduced ACPI platform are:
>> - * RSDP
>> - * RSDT
>> - * FADT
>> - * GTDT
>> - * MADT
>> - * MCFG
>> - * DSDT
>> - */
> I guess it's still debatable if the above change should be a separate
> patch or not. It'd probably be best if it was, or at least the commit
> message should contain an 'Also ...' sentence. Anyway, I'll leave it
> to the maintainers to decide.
Did you want to suggest a suitable addition to the commit message?
I have no idea; I'm just going to apply these to target-arm on the
basis of your review...