[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH v3] char: cadence: check baud rate ge
Re: [Qemu-arm] [Qemu-devel] [PATCH v3] char: cadence: check baud rate generator and divider values
Thu, 27 Oct 2016 12:02:04 -0700
On Wed, Oct 26, 2016 at 11:29 PM, P J P <address@hidden> wrote:
> +-- On Wed, 26 Oct 2016, Alistair Francis wrote --+
> | > * Device model for Cadence UART
> | > + * ->
> | Nit pick, I would put the URL under the title below.
> | > + case R_BRGR: /* Baud rate generator */
> | > + s->r[offset] = 0x028B; /* default reset value */
> | Why do we still have the reset value here, I thought we were just
> | ignoring the invalid writes? You don't need to reset it.
> Wouldn't that leave the registers undefined ?
No, they will just remain at whatever they were previously set to.
Which should always be valid.
> Thank you.
> Prasad J Pandit / Red Hat Product Security Team
> 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F