Re: [Qemu-arm] [Qemu-devel] [PATCH RFC 0/6] target-arm: KVM64: Cross type vCPU support

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH RFC 0/6] target-arm: KVM64: Cross type vCPU support

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
ad5e87b target-arm: cpu64: Add support for Cortex-A72
d4f6c86 arm: virt: Enable generic type CPU in virt machine
db2426e target: arm: Add a generic type cpu
042dff8 arm: kvm64: Check if kvm supports cross type vCPU
d8b8db1 target: arm: Add the qemu target for KVM_ARM_TARGET_GENERIC_V8
71eb07d headers: update linux headers

=== OUTPUT BEGIN ===
Checking PATCH 1/6: headers: update linux headers...
Checking PATCH 2/6: target: arm: Add the qemu target for 
KVM_ARM_TARGET_GENERIC_V8...
Checking PATCH 3/6: arm: kvm64: Check if kvm supports cross type vCPU...
ERROR: Macros with complex values should be enclosed in parenthesis
#21: FILE: target/arm/kvm64.c:484:
+#define ARM_CPU_ID_MIDR        3, 0, 0, 0, 0

ERROR: Macros with complex values should be enclosed in parenthesis
#24: FILE: target/arm/kvm64.c:487:
+#define ARM_CPU_ID_REVIDR      3, 0, 0, 0, 6

ERROR: Macros with complex values should be enclosed in parenthesis
#25: FILE: target/arm/kvm64.c:488:
+#define ARM_CPU_ID_AIDR        3, 1, 0, 0, 7

ERROR: Macros with complex values should be enclosed in parenthesis
#28: FILE: target/arm/kvm64.c:491:
+#define ARM_CPU_ID_CCSIDR      3, 1, 0, 0, 0

ERROR: Macros with complex values should be enclosed in parenthesis
#29: FILE: target/arm/kvm64.c:492:
+#define ARM_CPU_ID_CLIDR       3, 1, 0, 0, 1

ERROR: Macros with complex values should be enclosed in parenthesis
#30: FILE: target/arm/kvm64.c:493:
+#define ARM_CPU_ID_CSSELR      3, 2, 0, 0, 0

ERROR: Macros with complex values should be enclosed in parenthesis
#31: FILE: target/arm/kvm64.c:494:
+#define ARM_CPU_ID_CTR         3, 3, 0, 0, 1

ERROR: Macros with complex values should be enclosed in parenthesis
#34: FILE: target/arm/kvm64.c:497:
+#define ARM_CPU_ID_PFR0        3, 0, 0, 1, 0

ERROR: Macros with complex values should be enclosed in parenthesis
#35: FILE: target/arm/kvm64.c:498:
+#define ARM_CPU_ID_PFR1        3, 0, 0, 1, 1

ERROR: Macros with complex values should be enclosed in parenthesis
#36: FILE: target/arm/kvm64.c:499:
+#define ARM_CPU_ID_DFR0        3, 0, 0, 1, 2

ERROR: Macros with complex values should be enclosed in parenthesis
#37: FILE: target/arm/kvm64.c:500:
+#define ARM_CPU_ID_AFR0        3, 0, 0, 1, 3

ERROR: Macros with complex values should be enclosed in parenthesis
#38: FILE: target/arm/kvm64.c:501:
+#define ARM_CPU_ID_MMFR0       3, 0, 0, 1, 4

ERROR: Macros with complex values should be enclosed in parenthesis
#39: FILE: target/arm/kvm64.c:502:
+#define ARM_CPU_ID_MMFR1       3, 0, 0, 1, 5

ERROR: Macros with complex values should be enclosed in parenthesis
#40: FILE: target/arm/kvm64.c:503:
+#define ARM_CPU_ID_MMFR2       3, 0, 0, 1, 6

ERROR: Macros with complex values should be enclosed in parenthesis
#41: FILE: target/arm/kvm64.c:504:
+#define ARM_CPU_ID_MMFR3       3, 0, 0, 1, 7

ERROR: Macros with complex values should be enclosed in parenthesis
#42: FILE: target/arm/kvm64.c:505:
+#define ARM_CPU_ID_ISAR0       3, 0, 0, 2, 0

ERROR: Macros with complex values should be enclosed in parenthesis
#43: FILE: target/arm/kvm64.c:506:
+#define ARM_CPU_ID_ISAR1       3, 0, 0, 2, 1

ERROR: Macros with complex values should be enclosed in parenthesis
#44: FILE: target/arm/kvm64.c:507:
+#define ARM_CPU_ID_ISAR2       3, 0, 0, 2, 2

ERROR: Macros with complex values should be enclosed in parenthesis
#45: FILE: target/arm/kvm64.c:508:
+#define ARM_CPU_ID_ISAR3       3, 0, 0, 2, 3

ERROR: Macros with complex values should be enclosed in parenthesis
#46: FILE: target/arm/kvm64.c:509:
+#define ARM_CPU_ID_ISAR4       3, 0, 0, 2, 4

ERROR: Macros with complex values should be enclosed in parenthesis
#47: FILE: target/arm/kvm64.c:510:
+#define ARM_CPU_ID_ISAR5       3, 0, 0, 2, 5

ERROR: Macros with complex values should be enclosed in parenthesis
#48: FILE: target/arm/kvm64.c:511:
+#define ARM_CPU_ID_MMFR4       3, 0, 0, 2, 6

ERROR: Macros with complex values should be enclosed in parenthesis
#49: FILE: target/arm/kvm64.c:512:
+#define ARM_CPU_ID_MVFR0       3, 0, 0, 3, 0

ERROR: Macros with complex values should be enclosed in parenthesis
#50: FILE: target/arm/kvm64.c:513:
+#define ARM_CPU_ID_MVFR1       3, 0, 0, 3, 1

ERROR: Macros with complex values should be enclosed in parenthesis
#51: FILE: target/arm/kvm64.c:514:
+#define ARM_CPU_ID_MVFR2       3, 0, 0, 3, 2

ERROR: Macros with complex values should be enclosed in parenthesis
#52: FILE: target/arm/kvm64.c:515:
+#define ARM_CPU_ID_AA64PFR0    3, 0, 0, 4, 0

ERROR: Macros with complex values should be enclosed in parenthesis
#53: FILE: target/arm/kvm64.c:516:
+#define ARM_CPU_ID_AA64PFR1    3, 0, 0, 4, 1

ERROR: Macros with complex values should be enclosed in parenthesis
#54: FILE: target/arm/kvm64.c:517:
+#define ARM_CPU_ID_AA64DFR0    3, 0, 0, 5, 0

ERROR: Macros with complex values should be enclosed in parenthesis
#55: FILE: target/arm/kvm64.c:518:
+#define ARM_CPU_ID_AA64DFR1    3, 0, 0, 5, 1

ERROR: Macros with complex values should be enclosed in parenthesis
#56: FILE: target/arm/kvm64.c:519:
+#define ARM_CPU_ID_AA64AFR0    3, 0, 0, 5, 4

ERROR: Macros with complex values should be enclosed in parenthesis
#57: FILE: target/arm/kvm64.c:520:
+#define ARM_CPU_ID_AA64AFR1    3, 0, 0, 5, 5

ERROR: Macros with complex values should be enclosed in parenthesis
#58: FILE: target/arm/kvm64.c:521:
+#define ARM_CPU_ID_AA64ISAR0   3, 0, 0, 6, 0

ERROR: Macros with complex values should be enclosed in parenthesis
#59: FILE: target/arm/kvm64.c:522:
+#define ARM_CPU_ID_AA64ISAR1   3, 0, 0, 6, 1

ERROR: Macros with complex values should be enclosed in parenthesis
#60: FILE: target/arm/kvm64.c:523:
+#define ARM_CPU_ID_AA64MMFR0   3, 0, 0, 7, 0

ERROR: Macros with complex values should be enclosed in parenthesis
#61: FILE: target/arm/kvm64.c:524:
+#define ARM_CPU_ID_AA64MMFR1   3, 0, 0, 7, 1

ERROR: space required before the open parenthesis '('
#150: FILE: target/arm/kvm64.c:613:
+        if(id_regitsers[i].id != 0) {

WARNING: line over 80 characters
#194: FILE: target/arm/kvm64.c:679:
+            fprintf(stderr, "heterogeneous system can't support host guest CPU 
type\n");

total: 36 errors, 1 warnings, 207 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/6: target: arm: Add a generic type cpu...
WARNING: line over 80 characters
#63: FILE: target/arm/cpu64.c:250:
+    cpu->id_aa64mmfr0 = 0x0f001101; /* only support 4k page, 36 bit physical 
addr */

total: 0 errors, 1 warnings, 66 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 5/6: arm: virt: Enable generic type CPU in virt machine...
Checking PATCH 6/6: target-arm: cpu64: Add support for Cortex-A72...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden