qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [PATCH v2 7/9] arm: Track M profile handler mode state in


From: Peter Maydell
Subject: Re: [Qemu-arm] [PATCH v2 7/9] arm: Track M profile handler mode state in TB flags
Date: Thu, 20 Apr 2017 15:25:46 +0100

On 17 April 2017 at 05:20, Philippe Mathieu-Daudé <address@hidden> wrote:
> On 04/10/2017 02:13 PM, Peter Maydell wrote:
>> --- a/target/arm/translate.h
>> +++ b/target/arm/translate.h
>> @@ -31,6 +31,7 @@ typedef struct DisasContext {
>>      bool vfp_enabled; /* FP enabled via FPSCR.EN */
>>      int vec_len;
>>      int vec_stride;
>> +    bool handler; /* v7M Handler mode */
>
>
> What about a more descriptive name like 'is_v7m_handler_mode' or
> 'v7m_mode_handler'? It makes your next patch easier to understand:

Seems reasonable; I've made that change (but won't repost the
series as that's the only tweak).

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]