[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu-devel] [PATCH 09/19] nvic: Make set_pending and cle
From: |
Richard Henderson |
Subject: |
Re: [Qemu-arm] [Qemu-devel] [PATCH 09/19] nvic: Make set_pending and clear_pending take a secure parameter |
Date: |
Tue, 19 Sep 2017 13:41:32 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/12/2017 01:13 PM, Peter Maydell wrote:
> Make the armv7m_nvic_set_pending() and armv7m_nvic_clear_pending()
> functions take a bool indicating whether to pend the secure
> or non-secure version of a banked interrupt, and update the
> callsites accordingly.
>
> In most callsites we can simply pass the correct security
> state in; in a couple of cases we use TODO comments to indicate
> that we will return the code in a subsequent commit.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> target/arm/cpu.h | 14 ++++++++++-
> hw/intc/armv7m_nvic.c | 64
> ++++++++++++++++++++++++++++++++++++++-------------
> target/arm/helper.c | 24 +++++++++++--------
> hw/intc/trace-events | 4 ++--
> 4 files changed, 77 insertions(+), 29 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- Re: [Qemu-arm] [Qemu-devel] [PATCH 06/19] nvic: Make ICSR.RETTOBASE handle banked exceptions, (continued)
- [Qemu-arm] [PATCH 05/19] nvic: Implement AIRCR changes for v8M, Peter Maydell, 2017/09/12
- [Qemu-arm] [PATCH 07/19] nvic: Implement NVIC_ITNS<n> registers, Peter Maydell, 2017/09/12
- [Qemu-arm] [PATCH 12/19] nvic: In escalation to HardFault, support HF not being priority -1, Peter Maydell, 2017/09/12
- [Qemu-arm] [PATCH 10/19] nvic: Make SHPR registers banked, Peter Maydell, 2017/09/12
- [Qemu-arm] [PATCH 09/19] nvic: Make set_pending and clear_pending take a secure parameter, Peter Maydell, 2017/09/12
- Re: [Qemu-arm] [Qemu-devel] [PATCH 09/19] nvic: Make set_pending and clear_pending take a secure parameter,
Richard Henderson <=
- [Qemu-arm] [PATCH 01/19] target/arm: Implement MSR/MRS access to NS banked registers, Peter Maydell, 2017/09/12
- [Qemu-arm] [PATCH 15/19] nvic: Handle v8M changes in nvic_exec_prio(), Peter Maydell, 2017/09/12
- [Qemu-arm] [PATCH 13/19] nvic: Implement v8M changes to fixed priority exceptions, Peter Maydell, 2017/09/12
- [Qemu-arm] [PATCH 18/19] nvic: Make SHCSR banked for v8M, Peter Maydell, 2017/09/12
- [Qemu-arm] [PATCH 11/19] nvic: Compare group priority for escalation to HF, Peter Maydell, 2017/09/12