qemu-arm
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-arm] [RFC PATCH 19/30] Fix mask for AdvancedSIMD 2 reg misc


From: Richard Henderson
Subject: Re: [Qemu-arm] [RFC PATCH 19/30] Fix mask for AdvancedSIMD 2 reg misc
Date: Mon, 16 Oct 2017 16:47:31 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0

On 10/13/2017 09:24 AM, Alex Bennée wrote:
> While the group encoding declares bit 28 a zero it is set for
> FCMGT (zero)

I see that's what the documentation says.  Have you validated this?  It really
seems like an isolated typo.  Even if that is right, it isn't (documented) to
be set for the other simd_two_reg_misc_fp16 instructions.  So that means the
rest of your decode is compromised.

This patch needs folding into previous, anyway.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]