|
From: | bzt bzt |
Subject: | Re: [Qemu-arm] [Qemu-devel] [PATCH] BCM2837 and machine raspi3 |
Date: | Tue, 24 Oct 2017 18:30:40 +0200 |
Summa summarum, which one is preferred? Think of the future or keep it at a
bare minimum?
I don't feel I have a deciding word in this but to share my opinion I think it's better to keep it in one file avoiding too much code duplication as long as those features that would make the implementations different aren't added now. Then when those features are added the files could be split or the best way can be decided at that point based on how those features will be implemented so no need to think that far ahead now. This would make patches easier to review now and maintaining the common code easier until they are different enough so a split needs to be done.
Regrads,
BALATON Zoltan
[Prev in Thread] | Current Thread | [Next in Thread] |