[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-arm] [Qemu devel V4 PATCH] msf2: Remove dead code reported by
From: |
Peter Maydell |
Subject: |
Re: [Qemu-arm] [Qemu devel V4 PATCH] msf2: Remove dead code reported by Coverity |
Date: |
Mon, 30 Oct 2017 09:58:43 +0000 |
On 25 October 2017 at 03:29, Subbaraya Sundeep <address@hidden> wrote:
> Fixed incorrect frame size mask, validated maximum frame
> size in spi_write and removed dead code.
>
> Signed-off-by: Subbaraya Sundeep <address@hidden>
> ---
> v4:
> changed %d to %u while logging frame size error.
> v3:
> Added comment that [31:6] bits are reserved in R_SPI_DFSIZE
> register and logged incorrect value too in guest error(suggested
> by Darren).
> v2:
> else if -> else in set_fifodepth
> log guest error when frame size is more than 32
>
> hw/ssi/mss-spi.c | 18 ++++++++++++++----
> 1 file changed, 14 insertions(+), 4 deletions(-)
>
Applied to target-arm.next, thanks.
-- PMM